netdev - Re: [bug?] tg3: Failed to load firmware "tigon/tg3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 07 Jul 2008 13:24:37 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
CC:	David Woodhouse <dwmw2@...radead.org>,
	Andi Kleen <andi@...stfloor.org>,
	David Miller <davem@...emloft.net>, tytso@....edu,
	hugh@...itas.com, akpm@...ux-foundation.org,
	kosaki.motohiro@...fujitsu.com, mchan@...adcom.com,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	netdev@...r.kernel.org
Subject: Re: [bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin"

Alan Cox wrote:
>>> And we had the same argument over ten years ago about those evil module
>>> things which stopped you just using scp to copy the kernel in one go.
>>> Fortunately the nay sayers lost so we have modules.
>> Broken analogy.
>>
>> When modules were added, you were given the option to use them, or not.
> 
> You can still choose to compile firmware in. Did you read the patches ?

You cannot compile the firmware into the modules themselves, which is a 
regression from current behavior.

Its a problem for cases where you cannot as readily update the kernel 
image, such as vendor kernel + driver disk situations, or other examples 
already cited.

When the firmware travels with the module, as it does today in tg3, bnx2 
and others, is the most reliable system available.  The simplest, the 
least amount of "parts", the easiest to upgrade, the best method to 
guarantee driver/firmware version matches.  It works wonderfully today.

Is it difficult to see why someone might want to keep the same attributes?

Compiled-in firmware wastes memory and isn't upgradable -- just like 
static kernel vs. kernel modules debate -- but it IS far more reliable 
than any system where the firmware is separated from the kernel module 
itself.

I'd heartily support David's efforts if it was done in a regression-free 
manner.  But it is just so easy to build and package a _silently_ 
non-working driver, simply because the firmware got missed somewhere.

The best path to this new system is to (a) ensure the old system still 
works, and then (b) make it easy (transparent?) to adopt the new system.

	Jeff

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html