netdev - Re: Printing the driver name as part of the netdev watchdog message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080707171025.081e124f@infradead.org>
Date:	Mon, 7 Jul 2008 17:10:25 -0700
From:	Arjan van de Ven <arjan@...radead.org>
To:	Stephen Hemminger <shemminger@...tta.com>
Cc:	Roland Dreier <rdreier@...co.com>,
	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: Printing the driver name as part of the netdev watchdog message

On Mon, 7 Jul 2008 16:44:25 -0700
Stephen Hemminger <shemminger@...tta.com> wrote:

> On Mon, 07 Jul 2008 16:14:31 -0700
> Roland Dreier <rdreier@...co.com> wrote:
> 
> >  > I doubt it uses the RTNL semaphore elsewhere to protect
> >  > against this path, which is the only protection these
> >  > calls currently have.
> > 
> > As far as I can tell from reading the code, the only places in cxgb3
> > that use t3_read_flash() are in the netdevice's open and ioctl
> > methods, and the ethtool get_drvinfo method.  So as far as I can
> > tell the current code is fine as long as rtnl is held across
> > get_drvinfo.
> > 
> >  > Please don't bring up scarecrows, this looks like simply
> >  > a bug which already exists.
> > 
> > I don't even know how to take this.  "Please don't review our
> > changes"?? "Please don't report bugs"??
> > 
> >  - R.
> 
> Long term, it would be good to move the driver name into device
> struct? Easier and could work for all those random other drivers :-)

well we can already get it from the object model ;)
Dave just preferred to get it from ethtool and only get it from object
model if ethtool didn't work out.. (which makes sense)

I can see the point almost of having a generic_ethtool_getdrv which
just fills the struct from the object model data ;)



-- 
If you want to reach me at my work email, use arjan@...ux.intel.com
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html