netdev - Re: Printing the driver name as part of the netdev watchdog message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080708.165304.55424424.davem@davemloft.net>
Date:	Tue, 08 Jul 2008 16:53:04 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	arjan@...radead.org
Cc:	swise@...ngridcomputing.com, rdreier@...co.com,
	shemminger@...tta.com, netdev@...r.kernel.org
Subject: Re: Printing the driver name as part of the netdev watchdog message

From: Arjan van de Ven <arjan@...radead.org>
Date: Tue, 8 Jul 2008 16:48:26 -0700

> On Tue, 08 Jul 2008 14:57:38 -0700 (PDT)
> David Miller <davem@...emloft.net> wrote:
> 
> > What we need instead is to cache the info block into the netdev struct
> > when the driver is ->open()'d, and then you can fetch it out of
> > there however you like.
> 
> but.. isn't that like almost the same as using the object model data at
> that point?

You're right, this is getting silly

> I mean... if we had a "netdev_set_drivername()" thing with appropriate
> arguments (well I suck at names, name it whatever you feel like), we
> wouldn't need the drivers to implement each their own ethtool method,
> since this could just be done in one place and pull the data from the
> netdev.
> 
> (for the eeprom etc data that's different, but those are already
> different ethtool methods last I looked)

To be honest, the more I think about this, the driver->name should
be sufficient.

I just checked a bunch of PCI drivers and they provide the
same value for pci_driver->name as ethtool's info->driver

Sure, the ethtool info thing has a driver version etc. but
for your purposes that really doesn't add much.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html