netdev - Re: [PATCH v2] xfrm: Fix inter family IPsec tunnel handling again

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080708104022.GA26280@gondor.apana.org.au>
Date:	Tue, 8 Jul 2008 18:40:22 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Steffen Klassert <steffen.klassert@...unet.com>
Cc:	David Miller <davem@...emloft.net>, kaber@...sh.net,
	netdev@...r.kernel.org, klassert@...hematik.tu-chemnitz.de
Subject: Re: [PATCH v2] xfrm: Fix inter family IPsec tunnel handling again

On Tue, Jul 08, 2008 at 11:53:35AM +0200, Steffen Klassert wrote:
>
> Actually we are setting sel.family to the outer mode family if it is 
> unspecified from userspace, so it is always specified at this point. This was 
> changed by 
> commit bcf0dda8 ([XFRM]: xfrm_user: fix selector family initialization)
> because openswan seems to have problems if sel.family is not initialized.
> 
> But now the checks for AF_UNSPEC that are introduced by 
> commit df9dcb45 ([IPSEC]: Fix inter address family IPsec tunnel handling)
> return false. So the code that tries to choose for the right inner mode if
> sel.family was not specified from userspace is not executed and an 
> inter family tunnel does not work in this case.

I discussed this with Miyazawa-san earlier in the year.  In order
to maintain backwards compatibility, the use of AF_UNSPEC needs to
be combined with an SA flag.  So let's create a new flag that can
be set by the applications which needs the AF_UNSPEC behaviour.

That way you get what you want without breaking existing users such
as Openswan.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html