netdev - Re: [PATCH v3 2/2] hfsc: add link layer overhead adaption

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080708141135.174942dv1q2og4o4@hayate.ip6>
Date:	Tue, 08 Jul 2008 14:11:35 +0300
From:	"Jussi Kivilinna" <jussi.kivilinna@...et.fi>
To:	"Patrick McHardy" <kaber@...sh.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH v3 2/2] hfsc: add link layer overhead adaption

Quoting "Patrick McHardy" <kaber@...sh.net>:
>
> This means HFSC will use other packet sizes as inner qdiscs, policers,
> statistics etc, which I don't like very much. My original patch used
> the size tables to calculate the size when enqueing to the root qdisc
> and stored it in the cb, so all qdiscs in the hierarchy can use the
> same size.

With this patch I have tried to make HFSC support link layer emulation  
in same way as done in HTB with rate table, so that overhead is  
defined on leaf qdisc (if have understood right).

I have used this patch to have different overhead between qdisc leafs  
to account for extra overhead of ipv6-in-ipv4 tunnel (redirecting  
traffic to IMQ device and filtering ipv4&ipv6 to corresponding leafs).  
If overhead/linklayer is defined on root qdisc, this wouldn't be  
possible?

I'm not too happy about statistics being affected either, I'll look in to it.

>> @@ -987,9 +997,11 @@ hfsc_change_usc(struct hfsc_class *cl, struct   
>> tc_service_curve *usc,
>> }
>>  static const struct nla_policy hfsc_policy[TCA_HFSC_MAX + 1] = {
>> -	[TCA_HFSC_RSC]	= { .len = sizeof(struct tc_service_curve) },
>> -	[TCA_HFSC_FSC]	= { .len = sizeof(struct tc_service_curve) },
>> -	[TCA_HFSC_USC]	= { .len = sizeof(struct tc_service_curve) },
>> +	[TCA_HFSC_RSC]		= { .len = sizeof(struct tc_service_curve) },
>> +	[TCA_HFSC_FSC]		= { .len = sizeof(struct tc_service_curve) },
>> +	[TCA_HFSC_USC]		= { .len = sizeof(struct tc_service_curve) },
>> +	[TCA_HFSC_SZOPTS]	= { .len = sizeof(struct tc_sizespec) },
>> +	[TCA_HFSC_STAB]		= { .type = NLA_BINARY, .len = TC_STAB_SIZE },
>
> Why are these two separate attributes?

I copied qdisc_get_rtab() to qdisc_get_stab() and qdisc_get_rtab uses  
nla_data(tab) to get the buffer. Should use single attribute instead?
I have worked on patch that would merge qdisc_get_rtab/stab to generic  
qdisc_get_xtab supporting both types of link layer emulation tables.  
With single attribute here, patch wouldn't work so easily.

  - Jussi

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html