lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 8 Jul 2008 23:10:17 +0100 From: Ben Hutchings <bhutchings@...arflare.com> To: Patrick McHardy <kaber@...sh.net> Cc: Lennert Buytenhek <buytenh@...tstofly.org>, netdev@...r.kernel.org Subject: Re: [PATCH 1/2][RFC] vlan: use pskb_copy() when inserting a vlan tag by hand Patrick McHardy wrote: [...] > Without checking if its actually needed, I would tend to agree because > a caller can't rely on getting a linearized skb back except when its > guaranteed to be cloned, in the case it could simply copy it always. > > Anyway, the copy in __vlan_put_tag() is overkill since the header > is usually writable. See the patch I sent in my second mail, it > should reduce the overhead significantly. > > Actually there was a small bug in the one I sent, so attached again > to this mail. This looks great. Since our controller doesn't do VLAN tag insertion, I ran some quick tests and it improved TCP throughput over VLAN devices without TSO by about 50%. (With TSO on, the change wasn't so great - I think this was because the receive side couldn't do LRO on tagged packets.) Ben. -- Ben Hutchings, Senior Software Engineer, Solarflare Communications Not speaking for my employer; that's the marketing department's job. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists