netdev - Re: [PATCH 02/08]: vlan: deliver packets received with VLAN acceleration to network taps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4874B127.4080305@trash.net>
Date:	Wed, 09 Jul 2008 14:37:59 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	Ben Hutchings <bhutchings@...arflare.com>
CC:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH 02/08]: vlan: deliver packets received with VLAN acceleration
 to network taps

Ben Hutchings wrote:
> Patrick McHardy wrote:
>> vlan: deliver packets received with VLAN acceleration to network taps
>>
>> When VLAN header stripping is used, packets currently bypass packet
>> sockets (and other network taps) completely. For locally existing
>> VLANs, they appear directly on the VLAN device, for unknown VLANs
>> they are silently dropped.
>>
>> Add a new function netif_nit_deliver() to deliver incoming packets
>> to all network interface taps and use it in __vlan_hwaccel_rx() to
>> make VLAN packets visible on the underlying device.
> [...]
>> +/*
>> + * 	netif_tap_deliver - deliver received packets to network taps
>> + * 	@skb: buffer
>> + *
>> + * 	This function is used to deliver incoming packets to network
>> + * 	taps. It should be used when the normal netif_receive_skb path
>> + * 	is bypassed, for example because of VLAN acceleration.
>> + */
>> +void netif_nit_deliver(struct sk_buff *skb)
> [...]
> 
> Is it supposed to be called netif_nit_deliver() or netif_tap_deliver()?

Thanks, seems I only renamed it half way :)

Fixed patch attached.

View attachment "02.diff" of type "text/x-diff" (2940 bytes)