netdev - Re: bnx2_poll panicking kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1215728763.6901.23.camel@dell>
Date:	Thu, 10 Jul 2008 15:26:03 -0700
From:	"Michael Chan" <mchan@...adcom.com>
To:	"Josip Rodin" <joy@...uzijast.net>
cc:	"David Miller" <davem@...emloft.net>,
	"billfink@...dspring.com" <billfink@...dspring.com>,
	"bhutchings@...arflare.com" <bhutchings@...arflare.com>,
	netdev <netdev@...r.kernel.org>,
	"mirrors@...ian.org" <mirrors@...ian.org>
Subject: Re: bnx2_poll panicking kernel

On Thu, 2008-07-10 at 15:00 -0700, Josip Rodin wrote:
> > This is the same crash that you originally reported.  The driver was
> > referencing a NULL SKB because the skb_shinfo(skb)->nr_frags was
> > modified on the previous packet in the TX ring.
> >
> > If you had applied my debug patch #1 that I posted several weeks ago, it
> > should have avoided this because we should have saved away the nr_frags
> > for every packet on the TX ring.
> 
> It was that same patched kernel that crashed nevertheless.
> 

That's strange.  You also saw lots of "Corrupted SKB..." dmesg as well,
right?  May be the debug patch is not bullet-proof although I cannot see
how we can still get a NULL SKB in the TX completion path.

Anyway, please try today's patch as we need to find the source of the
problem.

Thanks.





--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html