netdev - Re: [PATCH 2/2] IPVS: Add genetlink interface implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080710144308.GV20815@postel.suug.ch>
Date:	Thu, 10 Jul 2008 16:43:08 +0200
From:	Thomas Graf <tgraf@...g.ch>
To:	Julius Volz <juliusv@...gle.com>
Cc:	Patrick McHardy <kaber@...sh.net>, netdev@...r.kernel.org,
	lvs-devel@...r.kernel.org, vbusam@...gle.com, horms@...ge.net.au,
	davem@...emloft.net
Subject: Re: [PATCH 2/2] IPVS: Add genetlink interface implementation

* Julius Volz <juliusv@...gle.com> 2008-07-10 15:58
> On Thu, Jul 10, 2008 at 2:15 PM, Patrick McHardy <kaber@...sh.net> wrote:
> > There probably should be a struct module *owner in the
> > ops registered with genetlink. This is necessary at
> > least to make sure that modules don't disappear during
> > dumps.
> 
> There seems to be no such thing in genetlink. af_netlink.c tracks the
> owner of a netlink socket, but that would increase the use count of
> the genetlink module.
> 
> First I would have suspected the genl_mutex to be held while dumping,
> so that at least unregistering the family at module unload would
> block. But the mutex is explicitly unlocked for the duration of the
> netlink dump:

It used to be like before the locking during dumps was revised. I
promised to redo the locking and module owner tracking but haven't
gotten around. Patrick's suggestion certainly makes sense.

> net/netlink/genetlink.c:
> 
>                 genl_unlock();
>                 err = netlink_dump_start(genl_sock, skb, nlh,
>                                          ops->dumpit, ops->done);
>                 genl_lock();
> 
> Julius
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html