netdev - Re: [PATCH] [IPV4] fib_trie: Fix lookup error return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080710105450.3ef6cd14@extreme>
Date:	Thu, 10 Jul 2008 10:54:50 -0700
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Ben Hutchings <bhutchings@...arflare.com>
Cc:	David Miller <davem@...emloft.net>,
	William Boughton <bill@...ghton.de>, netdev@...r.kernel.org,
	stephen.hemminger@...tta.com
Subject: Re: [PATCH] [IPV4] fib_trie: Fix lookup error return

On Thu, 10 Jul 2008 14:23:37 +0100
Ben Hutchings <bhutchings@...arflare.com> wrote:

> In commit a07f5f508a4d9728c8e57d7f66294bf5b254ff7f "[IPV4] fib_trie: style
> cleanup", the changes to check_leaf() and fn_trie_lookup() were wrong - where
> fn_trie_lookup() would previously return a negative error value from
> check_leaf(), it now returns 0.
>  
> Now fn_trie_lookup() doesn't appear to care about plen, so we can revert
> check_leaf() to returning the error value.
> 
> Signed-off-by: Ben Hutchings <bhutchings@...arflare.com>
> Tested-by: William Boughton <bill@...ghton.de>

Acked-by: Stephen Heminger <shemminger@...tta.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html