netdev - Re: [PATCH 1/6] via-velocity: remove the bounce buffers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4876EC1C.4080705@garzik.org>
Date:	Fri, 11 Jul 2008 01:14:04 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Francois Romieu <romieu@...zoreil.com>
CC:	netdev@...r.kernel.org,
	Séguier Régis <rseguier@...eleport.net>,
	akpm@...ux-foundation.org
Subject: Re: [PATCH 1/6] via-velocity: remove the bounce buffers

Francois Romieu wrote:
> Executive summary: the bounce buffers are in my way
> 
> - they use something like a 64 * 1500 bytes area of PCI
>   consistent area
> - they are not resized when the MTU changes
> - they are used
>   - to hand-pad undersized packets. skb_pad anyone ?
>   - to linearize fragmented skbs whose fragment count
>     goes beyond the 7 fragments hardware limit in order
>     to claim scatter-gather support
> 
> Actually the SG code is commented out and I wonder if it
> could not be implemented (ab-)using the large send feature
> of the chipset since the latter should support some
> multi-descriptor packet transmitting.
> 
> Signed-off-by: Francois Romieu <romieu@...zoreil.com>
> Fixed-by: Séguier Régis <rseguier@...eleport.net>
> ---
>  drivers/net/via-velocity.c |   72 +++++++++++---------------------------------
>  drivers/net/via-velocity.h |    5 ---
>  2 files changed, 18 insertions(+), 59 deletions(-)
> 

ACK patches 1-6

applied 1-4, patch #5 failed to apply


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html