netdev - Re: [PATCH RESEND] dm9601: don't do usb transfers of data on stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200807111400.38312.oliver@neukum.org>
Date:	Fri, 11 Jul 2008 14:00:37 +0200
From:	Oliver Neukum <oliver@...kum.org>
To:	Peter Korsgaard <jacmet@...site.dk>
Cc:	jeff@...zik.org, netdev@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH RESEND] dm9601: don't do usb transfers of data on stack

Am Freitag 11 Juli 2008 13:37:39 schrieb Peter Korsgaard:
> dm_{read,write}_shared_word() were doing USB transfers of data on stack,
> which isn't allowed. Fix it by using the usbnet->data area like in
> dm9601_set_multicast().

You cannot do this. You've identified the bug correctly, but the fix
is incorrect. Doing DMA on non coherent architectures means that
any cacheline the buffer shares must not be touched while DMA
may be running. If you embed the buffer into struct usbnet, how could
you meet the guarantee?

	Regards
		Oliver
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html