netdev - Re: [PATCH RESEND] dm9601: don't do usb transfers of data on stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87r6a0eg10.fsf@macbook.be.48ers.dk>
Date:	Fri, 11 Jul 2008 14:55:55 +0200
From:	Peter Korsgaard <jacmet@...site.dk>
To:	Oliver Neukum <oliver@...kum.org>
Cc:	jeff@...zik.org, netdev@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH RESEND] dm9601: don't do usb transfers of data on stack

>>>>> "Oliver" == Oliver Neukum <oliver@...kum.org> writes:

Hi,

 >> Ahh. So kmalloc() / kfree() around the usb_control_msg isn dm_read /
 >> dm_write is the way to go?

 Oliver> The buffer should be allocated with kmalloc. That doesn't
 Oliver> mean it has to be allocated each time the function is
 Oliver> called. If several drivers do this, the best fix is to modify
 Oliver> struct usbnet so that it contains only a pointer to the
 Oliver> buffer, not the buffer itself and modify drivers accordingly.

Ok, but this is just for a few config registers - Nothing in the fast
path, so I'll keep it simple.

-- 
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html