netdev - Re: [PATCH 11/39]: netdev: Move next_sched into struct netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080714122733.GA4573@ff.dom.local>
Date:	Mon, 14 Jul 2008 12:27:33 +0000
From:	Jarek Poplawski <jarkao2@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, vinay@...ux.vnet.ibm.com,
	krkumar2@...ibm.com, mchan@...adcom.com, Matheos.Worku@....COM,
	linux-wireless@...r.kernel.org
Subject: Re: [PATCH 11/39]: netdev: Move next_sched into struct
	netdev_queue.

On Mon, Jul 14, 2008 at 05:00:11AM -0700, David Miller wrote:
> From: Jarek Poplawski <jarkao2@...il.com>
> Date: Mon, 14 Jul 2008 11:49:13 +0000
> 
> > On 03-07-2008 09:03, David Miller wrote:
> > > We schedule queues, not the device, for output queue
> > > processing in BH.
> > > 
> > ...
> > > diff --git a/net/core/dev.c b/net/core/dev.c
> > > index 8e38948..c5e3532 100644
> > > --- a/net/core/dev.c
> > > +++ b/net/core/dev.c
> > > @@ -1323,13 +1323,14 @@ static void dev_queue_xmit_nit(struct sk_buff *skb, struct net_device *dev)
> > >  void __netif_schedule(struct net_device *dev)
> > >  {
> > >  	if (!test_and_set_bit(__LINK_STATE_SCHED, &dev->state)) {
> > 
> > Isn't this bit supposed to be set/tested per queue as well, or do I
> > miss something?
> 
> That shoule not happen until my later patches which switch that all
> over.
> 
> See patch 5/13 which I posted on Thursday, Jul 10.  That's when the
> transition from "global queue state + per-queue state" into "only
> per-queue state" happens.
> 
> Until that point, we have to keep the existing quasi-multi-queue
> semantics in order to not break drivers etc.

I've just wondered how this 1-13/13 step can work without this...

Jarek P.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html