netdev - Re: bnx2_poll panicking kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <487B7061.5040306@trash.net>
Date:	Mon, 14 Jul 2008 17:27:29 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	Jarek Poplawski <jarkao2@...il.com>
CC:	David Miller <davem@...emloft.net>, joy@...uzijast.net,
	mchan@...adcom.com, billfink@...dspring.com,
	bhutchings@...arflare.com, netdev@...r.kernel.org,
	mirrors@...ian.org, devik@....cz
Subject: Re: bnx2_poll panicking kernel

Jarek Poplawski wrote:
> Jarek Poplawski wrote, On 07/12/2008 11:49 AM:
> 
>> This isn't correct: htb_activate() needs cl->un.leaf.q->q.qlen > 0, and
>> only NET_XMIT_SUCCESS can guarantee this.
> 
> 
> ...Actually, it looks like even NET_XMIT_SUCCESS can't guarantee this
> (when returned after TC_ACT_QUEUED or TC_ACT_STOLEN), so additional qlen
> test is needed here.

The TC action code translation needs to be fixed instead.

I didn't manage to work on this this weekend as I intended, but
I'll take care of it soon unless someone beats me to it.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html