netdev - Re: bnx2_poll panicking kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080714202151.GA28622@orion.carnet.hr>
Date:	Mon, 14 Jul 2008 22:21:51 +0200
From:	Josip Rodin <joy@...uzijast.net>
To:	Jarek Poplawski <jarkao2@...il.com>
Cc:	Patrick McHardy <kaber@...sh.net>,
	David Miller <davem@...emloft.net>, mchan@...adcom.com,
	billfink@...dspring.com, bhutchings@...arflare.com,
	netdev@...r.kernel.org, mirrors@...ian.org, devik@....cz
Subject: Re: bnx2_poll panicking kernel

On Mon, Jul 14, 2008 at 07:20:55PM +0200, Jarek Poplawski wrote:
> On Mon, Jul 14, 2008 at 05:27:29PM +0200, Patrick McHardy wrote:
> > Jarek Poplawski wrote:
> >> Jarek Poplawski wrote, On 07/12/2008 11:49 AM:
> >>
> >>> This isn't correct: htb_activate() needs cl->un.leaf.q->q.qlen > 0, and
> >>> only NET_XMIT_SUCCESS can guarantee this.
> >>
> >>
> >> ...Actually, it looks like even NET_XMIT_SUCCESS can't guarantee this
> >> (when returned after TC_ACT_QUEUED or TC_ACT_STOLEN), so additional qlen
> >> test is needed here.
> >
> > The TC action code translation needs to be fixed instead.
> >
> > I didn't manage to work on this this weekend as I intended, but
> > I'll take care of it soon unless someone beats me to it.
> 
> IMHO, since this TC_ACT_ issue looks quite rare, David's patch, with
> "htb_activate()" moved to the last "if (ret == NET_XMIT_SUCCESS)"
> blocks, looks like necessary.
> 
> BTW, I wonder how Josip's testing?

Do you want me to try out David's patch? I was hoping to get a definite okay
from someone before applying it, given that this is a production machine
for us and we do need it in *some* kind of an operational state.

I've got many more tens of kilobytes of logs from the previous debugging
patches, if you want I can send them over.

-- 
     2. That which causes joy or happiness.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html