netdev - Re: [PATCH RFC 01/10] mlx4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <adafxqbdk02.fsf@cisco.com>
Date:	Tue, 15 Jul 2008 12:29:01 -0700
From:	Roland Dreier <rdreier@...co.com>
To:	Yevgeny Petrilin <yevgenyp@...lanox.co.il>
Cc:	jeff@...zik.org, netdev@...r.kernel.org,
	Liran Liss <liranl@...lanox.co.il>, tziporet@...lanox.co.il
Subject: Re: [PATCH RFC 01/10] mlx4_en: Include file

 > +enum mlx4_en_state {
 > +	DEVICE_DOWN,
 > +	DEVICE_UP,
 > +	DEVICE_GOING_DOWN,
 > +	DEVICE_DISABLED
 > +};

I don't see any place that sets the state to anything other than UP or
DOWN.  Maybe it would be clearer to get rid of the enum and just have

	bool      device_up;

in your structure?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html