netdev - Re: data received but not detected

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1216154784.3084.151.camel@cheeto.emacinc.com>
Date:	Tue, 15 Jul 2008 15:46:24 -0500
From:	Travis Stratman <tstratman@...cinc.com>
To:	James Chapman <jchapman@...alix.com>
Cc:	netdev@...r.kernel.org
Subject: Re: data received but not detected

On Tue, 2008-07-08 at 10:37 +0100, James Chapman wrote:
> 
> The rx and tx status are flagged in the same status register. The bits 
> are set regardless of whether rx or tx interrupts are enabled in the 
> device. So when you handle a tx interrupt, the interrupt routine will 
> read the status register and may see rx bits also set.

That makes sense, I was making an incorrect assumption.
> 
> You could mask the status register value that you read to ignore rx bits 
> if rx interrupts are disabled (NAPI polled mode). But to be honest, I 
> think it is simpler to handle rx _and_ tx work in the NAPI poll handler 
> so you only get interrupts when not in NAPI polled mode. See tg3.c or 
> e100.c for example.

I will take a look at modifying the driver to use NAPI for tx.

Thanks,

Travis

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html