netdev - Re: [PATCH 4/5] virtio net: Allow receiving SG packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080715035209.GB2657@gondor.apana.org.au>
Date:	Tue, 15 Jul 2008 11:52:09 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Rusty Russell <rusty@...tcorp.com.au>
Cc:	Jeff Garzik <jeff@...zik.org>,
	virtualization@...ts.linux-foundation.org, netdev@...r.kernel.org
Subject: Re: [PATCH 4/5] virtio net: Allow receiving SG packets

On Mon, Jul 14, 2008 at 10:41:38PM -0500, Rusty Russell wrote:
>
> +	/* If we can receive ANY GSO packets, we must allocate large ones. */
> +	if (virtio_has_feature(vdev, VIRTIO_NET_F_GUEST_TSO4)
> +	    || virtio_has_feature(vdev, VIRTIO_NET_F_GUEST_TSO6)
> +	    || virtio_has_feature(vdev, VIRTIO_NET_F_GUEST_ECN))
> +		dev->features |= NETIF_F_LRO;

We don't want to do this because LRO implies joining packets
together in an irreversible way which is not what this is about.

Case in point we're now disabling LRO for devices that are
forwarding packets which is totally unnecessary for virtio.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html