netdev - Re: v4 [PATCH 6/9] ipv4: Check return of dev_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080714.205543.13885497.davem@davemloft.net>
Date:	Mon, 14 Jul 2008 20:55:43 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	wangchen@...fujitsu.com
Cc:	kaber@...sh.net, netdev@...r.kernel.org
Subject: Re: v4 [PATCH 6/9] ipv4: Check return of dev_set_allmulti

From: Wang Chen <wangchen@...fujitsu.com>
Date: Tue, 15 Jul 2008 10:59:35 +0800

> allmulti might overflow.
> Commit: "netdevice: Fix promiscuity and allmulti overflow" in net-next makes
> dev_set_promiscuity/allmulti return error number if overflow happened.
> 
> Here, we check the positive increment for allmulti to get error return.
> 
> PS: For unwinding tunnel creating, we let ipip->ioctl() to handle it.
> 
> Signed-off-by: Wang Chen <wangchen@...fujitsu.com>

Unwinding is ugly, but I can't suggest a better way right now :)

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html