netdev - Re: [PATCH] af_packet: po->mclist needs locker in reader side

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080715.021144.85711463.davem@davemloft.net>
Date:	Tue, 15 Jul 2008 02:11:44 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	wangchen@...fujitsu.com
Cc:	kaber@...sh.net, netdev@...r.kernel.org
Subject: Re: [PATCH] af_packet: po->mclist needs locker in reader side

From: Wang Chen <wangchen@...fujitsu.com>
Date: Tue, 15 Jul 2008 15:52:31 +0800

> As my understanding, packet_dev_mclist() is the only reader who doesn't
> use same lock as writers(actually it doesn't use any lock).
> My proposal is that use RTNL to prevent synchronous access to po->mclist.
> Because packet_dev_mclist() is only called when device be unregistered,
> the lock will not affect speed too much. 
> 
> Signed-off-by: Wang Chen <wangchen@...fujitsu.com>

I took a look and it turns out that the RTNL lock is already held when
that notifier runs, so it seems everything is fine here already.

So I'll ignore this patch :)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html