netdev - Re: TXQ real_num_tx_queues comments/questions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1216113923.3535.14.camel@johannes.berg>
Date:	Tue, 15 Jul 2008 11:25:23 +0200
From:	Johannes Berg <johannes@...solutions.net>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, linux-wireless@...r.kernel.org
Subject: Re: TXQ real_num_tx_queues comments/questions


[...]

> > I like the RCU variant better, as it means we don't need a "central"
> > lock that is taken for all tx queues, and it also allows other drivers
> > to actually change real_num_tx_queues in a similar fashion, should that
> > ever be required.
> 
> It seems to me that a simple synchronize_net() call near the end of
> agg queue removal would solve your problem as-is, wouldn't it?

Well, as far as I can tell we can't do that there because it's in
tasklet context/called under spinlocks so it has to be atomic. I think.

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)