netdev - [PATCH RFC] net_sched: add generic qdisc size table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080717024055.18323q4r4ll8sf0g@hayate.ip6>
Date:	Thu, 17 Jul 2008 02:40:55 +0300
From:	"Jussi Kivilinna" <jussi.kivilinna@...et.fi>
To:	"Patrick McHardy" <kaber@...sh.net>
Cc:	netdev@...r.kernel.org
Subject: [PATCH RFC] net_sched: add generic qdisc size table

Quoting "Patrick McHardy" <kaber@...sh.net>:

> Jussi Kivilinna wrote:
>> Quoting "Patrick McHardy" <kaber@...sh.net>:
>>
>>>
>>> I thought you were going to make this a generic qdisc feature.
>>> Why is configuration still qdisc specific?
>>>
>>
>> I was thinking keeping scope of this patch within hfsc, as done   
>> with rest of rate table qdiscs. So it would be better to have they   
>> all to use generic size table instead of duplicating rtab code.
>
> Well, to use this feature consistently (meaning sizes propagate
> down to inner qdiscs) it needs to be a generic feature.
>
>>> I was thinking of something like this:
>>>
>>> - add generic attributes for configuring size tables for any
>>>  qdisc, handle those in sch_api
>>>
>>> - add qdisc_enqueue() wrapper that calculates the size and
>>>  stores it in skb->cb, convert direct calls of sch->enqueue
>>>  to use it
>>>
>>> - change direct uses of skb->len to use the size from the cb
>>>
>>> The second step might need a bit more thought to make sure
>>> qdiscs don't get confused when the dequeued packet is larger
>>> than the enqueued one, but I think they usually don't care.
>>>
>>
>> I guess I'll start over using your size table patch as base then.
>
> I'm not sure that part is correct in my patch :)
>

Here's first version of generic size table feature. Didn't get chance  
to test too much yet but hfsc&sfq seems to be ok.

  - Jussi

View attachment "01-add-qdisc_enqueue-wrapper.diff" of type "text/x-patch" (8168 bytes)

View attachment "02-add-accessor-function-for-packet-len-for-qdiscs.diff" of type "text/x-patch" (16704 bytes)

View attachment "03-add-size-table-for-qdiscs.diff" of type "text/x-patch" (10634 bytes)

View attachment "01-iproute-add-size-table.diff" of type "text/x-patch" (10970 bytes)