netdev - Re: [PATCH 1/2] 8139too: Make PIO/MMIO a modparam

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 16 Jul 2008 12:03:41 +0200
From:	Peter Korsgaard <jacmet@...site.dk>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	Dave Jones <davej@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	netdev@...r.kernel.org
Subject: Re: [PATCH 1/2] 8139too: Make PIO/MMIO a modparam

>>>>> "Jeff" == Jeff Garzik <jeff@...zik.org> writes:

 >> > * [optional] if code not too ugly, change mod param description
 >> based on  > CONFIG_8139TOO_PIO to indicate the currently compiled
 >> default
 >> 
 >> Not sure of a non-icky way to do this other than ifdefs.
 >> The best I could come up with is.
 >> 
 >> #ifdef CONFIG_8139TOO_PIO
 >> MODULE_PARM_DESC(use_io, "PIO/MMIO switch.  0=MMIO 1=PIO
 >> default=PIO"); #else
 >> MODULE_PARM_DESC(use_io, "PIO/MMIO switch.  0=MMIO 1=PIO
 >> default=MMIO"); #endif
 >> 
 >> palatable?

 Jeff> best you can do AFAIK, so yes

Something like:
#ifdef CONFIG_8139TOO_PIO
#define DEFAULTMODE "PIO"
#else
#define DEFAULTMODE "MMIO"
#endif

MODULE_PARM_DESC(use_io, "PIO/MMIO switch.  0=MMIO 1=PIO default=" DEFAULTMODE);

would be nicer.

-- 
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html