[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <72981EBCFD196144B7C6999B9FC34A9A3EE613106D@SHEXMB-01.global.atheros.com>
Date: Thu, 17 Jul 2008 10:47:07 +0800
From: Jie Yang <Jie.Yang@...eros.com>
To: Roland Dreier <rdreier@...co.com>
CC: Stephen Hemminger <shemminger@...tta.com>,
"jeff@...zik.org" <jeff@...zik.org>,
David Miller <davem@...emloft.net>,
"jcliburn@...il.com" <jcliburn@...il.com>,
"parag.warudkar@...il.com" <parag.warudkar@...il.com>,
Willy Tarreau <w@....eu>,
"oliver.schuster@...weigstill.de" <oliver.schuster@...weigstill.de>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH net-next] atl1e: Atheros L1E Gigabit Ethernet driver
On Thursday, July 17, 2008 12:36 AM
Roland Dreier <rdreier@...co.com> wrote:
>
> > Output of checkpatch (scripts/checkpatch.pl in kernel source).
> > Personally, I am not a whitespace bigot, and don't think
> > all the warnings in checkpatch have to be fixed.
> >
> > ----------
> > ERROR: patch seems to be corrupt (line wrapped?) > #121:
> FILE: drivers/net/atl1e/atl1e.h:9:
> > ree
> >
> > WARNING: space prohibited between function name and open
> parenthesis '('
> > #212: FILE: drivers/net/atl1e/atl1e.h:97:
> > + _tpd =3D (((_vlan) << (4)) | (((_vlan) >> 13) & 7) |\
>
> It's kind of pointless to run checkpatch on a corrupted patch
> (the email was quoted-printable and you didn't decode it back
> to text). Of course it's also better to send non-mangled patches.
>
> - R.
>
Hi, Roland
I used outlook to send these patches, can you give me some
aderise on how to send non-mangled patches.
Best wishes
jie
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists