netdev - Re: [PATCH RFC 2/3] net_sched: Add accessor function for packet length for qdiscs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080717143333.188544nw52n0v6dc@hayate.ip6>
Date:	Thu, 17 Jul 2008 14:33:33 +0300
From:	"Jussi Kivilinna" <jussi.kivilinna@...et.fi>
To:	"Patrick McHardy" <kaber@...sh.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH RFC 2/3] net_sched: Add accessor function for packet
	length for qdiscs

Quoting "Patrick McHardy" <kaber@...sh.net>:

> Jussi Kivilinna wrote:
>> Signed-off-by: Jussi Kivilinna <jussi.kivilinna@...et.fi>
>> ---
>>
>> include/net/sch_generic.h |   17 +++++++++++------
>> net/sched/sch_atm.c       |    4 ++--
>> net/sched/sch_cbq.c       |   14 ++++++--------
>> net/sched/sch_dsmark.c    |    2 +-
>> net/sched/sch_fifo.c      |    2 +-
>> net/sched/sch_gred.c      |   12 ++++++------
>> net/sched/sch_hfsc.c      |   14 ++++++--------
>> net/sched/sch_htb.c       |    9 +++++----
>> net/sched/sch_netem.c     |    6 +++---
>> net/sched/sch_prio.c      |    2 +-
>> net/sched/sch_red.c       |    2 +-
>> net/sched/sch_sfq.c       |   16 ++++++++--------
>> net/sched/sch_tbf.c       |    9 ++++++---
>> net/sched/sch_teql.c      |    6 +++---
>> 14 files changed, 60 insertions(+), 55 deletions(-)
>>
>> diff --git a/include/net/sch_generic.h b/include/net/sch_generic.h
>> index e3b0d71..1f1de3b 100644
>> --- a/include/net/sch_generic.h
>> +++ b/include/net/sch_generic.h
>> @@ -258,6 +258,11 @@ static inline bool qdisc_tx_is_noop(const   
>> struct net_device *dev)
>> 	return (txq->qdisc == &noop_qdisc);
>> }
>> +static inline unsigned int qdisc_tx_len(struct sk_buff *skb)
>> +{
>> +	return skb->len;
>> +}
>
>
> Just one question - should this also be useable for ingress? If so
> a different name would make sense.
>
>

Yes, it should be. Police action has rate table that could be replaced  
with size table, so qdisc_pkt_len() would be better name.

  - Jussi

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html