netdev - Re: [PATCH 3/4] sfc: resolve tx multiqueue bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080718184925.GJ10471@solarflare.com>
Date:	Fri, 18 Jul 2008 19:49:26 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Jeff Garzik <jgarzik@...ox.com>
Cc:	netdev@...r.kernel.org, linux-net-drivers@...arflare.com
Subject: Re: [PATCH 3/4] sfc: resolve tx multiqueue bug

Ben Hutchings wrote:
> With the recent changes to tx multiqueue, sfc was not calling
> netif_start_queue() before calling netif_wake_queue().
> This causes an oops when opening a device.
> 
> Signed-off-by: Ben Hutchings <bhutchings@...arflare.com>
> ---
>  drivers/net/sfc/tx.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/sfc/tx.c b/drivers/net/sfc/tx.c
> index 5cdd082..798b06b 100644
> --- a/drivers/net/sfc/tx.c
> +++ b/drivers/net/sfc/tx.c
> @@ -53,6 +53,7 @@ inline void efx_wake_queue(struct efx_nic *efx)
>  	if (atomic_dec_and_lock(&efx->netif_stop_count,
>  				&efx->netif_stop_lock)) {
>  		EFX_TRACE(efx, "waking TX queue\n");
> +		netif_start_queue(efx->net_dev);
>  		netif_wake_queue(efx->net_dev);
>  		spin_unlock(&efx->netif_stop_lock);
>  	}

Ahem... ignore this, it's obviously not right.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html