netdev - Re: [Resend v2 PATCH 2/3] TCP: options clean up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080719.000641.12271128.davem@davemloft.net>
Date:	Sat, 19 Jul 2008 00:06:41 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	agl@...erialviolet.org
Cc:	netdev@...r.kernel.org
Subject: Re: [Resend v2 PATCH 2/3] TCP: options clean up

From: "Adam Langley" <agl@...erialviolet.org>
Date: Thu, 17 Jul 2008 16:08:10 -0700

> This should fix the following bugs:
>   * Connections with MD5 signatures produce invalid packets whenever SACK
>     options are included
>   * MD5 signatures are counted twice in the MSS calculations
> 
> Behaviour changes:
>   * A SYN with MD5 + SACK + TS elicits a SYNACK with MD5 + SACK
> 
>     This is because we can't fit any SACK blocks in a packet with MD5 + TS
>     options. There was discussion about disabling SACK rather than TS in
>     order to fit in better with old, buggy kernels, but that was deemed to
>     be unnecessary.
> 
>   * SYNs with MD5 don't include a TS option
> 
>     See above.
> 
> Additionally, it removes a bunch of duplicated logic for calculating options,
> which should help avoid these sort of issues in the future.
> 
> Signed-off-by: Adam Langley <agl@...erialviolet.org>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html