netdev - Re: [PATCH 2/3] ucc_geth: do not touch net queue in adjust

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080721.083051.39701172.davem@davemloft.net>
Date:	Mon, 21 Jul 2008 08:30:51 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	avorontsov@...mvista.com
Cc:	jeff@...zik.org, netdev@...r.kernel.org
Subject: Re: [PATCH 2/3] ucc_geth: do not touch net queue in adjust_link
 phylib callback

From: Anton Vorontsov <avorontsov@...mvista.com>
Date: Mon, 21 Jul 2008 19:17:35 +0400

> If the net queue has not been started, we'll get this nice oops
> and non-working ethernet:
 ...
> Since the driver is using phylib (which is doing netif_carrier_on/off()),
> we should simply remove netif_tx_schedule_all() from adjust_link().
> 
> Signed-off-by: Anton Vorontsov <avorontsov@...mvista.com>

Also applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html