netdev - Re: [PATCH 20/31]: pkt_sched: Perform bulk of qdisc destruction in RCU.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080721.100821.38432201.davem@davemloft.net>
Date:	Mon, 21 Jul 2008 10:08:21 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	herbert@...dor.apana.org.au
Cc:	hadi@...erus.ca, kaber@...sh.net, netdev@...r.kernel.org,
	johannes@...solutions.net, linux-wireless@...r.kernel.org
Subject: Re: [PATCH 20/31]: pkt_sched: Perform bulk of qdisc destruction in
 RCU.

From: Herbert Xu <herbert@...dor.apana.org.au>
Date: Tue, 22 Jul 2008 01:02:33 +0800

> On Mon, Jul 21, 2008 at 09:51:24AM -0700, David Miller wrote:
> >
> > How so?  If the TX hash is well distributed, which it should be,
> > it is at least going to approximate the distribution provided by
> > the RX hash.
> 
> This is a matter of probabilities :) In general, if the TX hash
> and the RX hash are completely unrelated, then the end result of
> the hash distribution should be independent of each other (independent
> in the probablistic sense).  That is, for the flows which have
> been RX hashed into one queue, they should be hashed on average
> across all queues by the TX hash.  Conversely, those that have
> been hashed into one TX queue would be distributed across all
> RX queues.

Theoretically perhaps you are right.

Can I at least get some commitment that someone will test
that this really is necessary before we add the CPU ID
hash option?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html