netdev - Re: [PATCH 20/31]: pkt_sched: Perform bulk of qdisc destruction in RCU.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080721031716.GA7535@gondor.apana.org.au>
Date:	Mon, 21 Jul 2008 11:17:16 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	jamal <hadi@...erus.ca>
Cc:	kaber@...sh.net, davem@...emloft.net, netdev@...r.kernel.org,
	johannes@...solutions.net, linux-wireless@...r.kernel.org
Subject: Re: [PATCH 20/31]: pkt_sched: Perform bulk of qdisc destruction in	RCU.

On Sun, Jul 20, 2008 at 10:33:57PM -0400, jamal wrote:
> 
> True. 
> But note: this is only during rule creation - once you create the
> rule (user space to kernel path), then no more hash table reference.
> Fast path has already a filter with actions attached, and is a mere
> pointer dereference.

Unfortunately the scenario that I wrote this for requires frequent
addition/removal.

> > We could do a dynamic table but so far I'm not convinced that
> > it's worth anybody's effort to implement :)
> 
> If user<->kernel performance insertion/deletion is important, it is
> worth it.

Only if you also want to share it :) In the end I patched it to
not share it which is much easier.

> For example:
> Dave implemented dynamic hash tables on xfrm (voip setup time with ipsec
> is a metric used in the industry in that case) . The only operational
> problem i had with xfrm was lack of an upper bound of how large a table
> can grow; i would rather user space be told ENOMEM than continuing to
> grow in some cases (I actually implemented a patch which put a stop
> after a certain number of sad/spd - but i dont expect hugs if i was to
> post it;->).

Of course if you're volunteering to write the dynamic hash table
for actions then I'd happily switch back to sharing :)

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html