netdev - Re: [bug, netconsole, SLUB] BUG skbuff_head

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080721.163349.113841731.davem@davemloft.net>
Date:	Mon, 21 Jul 2008 16:33:49 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	johnpol@....mipt.ru
Cc:	mingo@...e.hu, penberg@...helsinki.fi,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	vegard.nossum@...il.com, rjw@...k.pl, cl@...ux-foundation.org,
	auke-jan.h.kok@...el.com
Subject: Re: [bug, netconsole, SLUB] BUG skbuff_head_cache: Poison
 overwritten

From: Evgeniy Polyakov <johnpol@....mipt.ru>
Date: Tue, 22 Jul 2008 01:24:48 +0400

> On Mon, Jul 21, 2008 at 09:21:38PM +0200, Ingo Molnar (mingo@...e.hu) wrote:
> > So it's now a strong likelyhood that this crash is a combination of 
> > e1000e+netconsole.
> 
> e1000_clean_tx_irq() call looks particulary suspicious: it is called
> without adapter->tx_queue_lock in poll controller (netconsole callback)
> and with that lock in NAPI handler.
> 
> Can you check kind of this patch:

The call even seems pointless, since the caller will call
->poll() (which is e1000_clean) as the very next action,
and that will invoke e1000_clean_tx_irq() properly.

I would just delete this call from e1000_netpoll() entirely.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html