netdev - Re: [PATCH 20/31]: pkt_sched: Perform bulk of qdisc destruction in RCU.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080721113600.GA10322@gondor.apana.org.au>
Date:	Mon, 21 Jul 2008 19:36:00 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	jamal <hadi@...erus.ca>
Cc:	kaber@...sh.net, davem@...emloft.net, netdev@...r.kernel.org,
	johannes@...solutions.net, linux-wireless@...r.kernel.org
Subject: Re: [PATCH 20/31]: pkt_sched: Perform bulk of qdisc destruction in RCU.

On Mon, Jul 21, 2008 at 07:14:39AM -0400, jamal wrote:
> 
> > Only if you also want to share it :) In the end I patched it to
> > not share it which is much easier.
> 
> I am trying to visualize: if you dont share, you must have 256K copies
> then? Assuming also you have a fast lookup since that was design intent.

They can't be shared anyway because each of those 256K rules NATs
to a different IP address.

> #ifdef CONFIG_HASH_SIZE
> #define NAT_TAB_MASK CONFIGURED_HASH_SIZE
> #else
> #define NAT_TAB_MASK 15
> #endif
> 
> What do you think?

Sorry, I think I'll have to poke my eyes out :)

But yeah if we ever get a generic dynamic hash table implmenetation
then I'd be happy for act_nat to use that.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html