netdev - Re: [GIT]: Networking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080721115742.GA4871@martell.zuzino.mipt.ru>
Date:	Mon, 21 Jul 2008 15:57:42 +0400
From:	Alexey Dobriyan <adobriyan@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	jeffrey.t.kirsher@...el.com
Subject: Re: [GIT]: Networking

On Sun, Jul 20, 2008 at 10:11:06PM -0700, David Miller wrote:
> From: David Miller <davem@...emloft.net>
> Date: Sun, 20 Jul 2008 19:48:56 -0700 (PDT)
> 
> > From: Alexey Dobriyan <adobriyan@...il.com>
> > Date: Mon, 21 Jul 2008 06:40:56 +0400
> > 
> > > OK, the problem is really this buglet:
> > > 
> > > 	BUG_ON(q == &noop_qdisc);
> > > 	__netif_schedule
> > > 	netif_tx_wake_queue
> > > 	netif_wake_queue
> > > 	atl1_check_link
> > > 	atl1_up		or	atlx_link_chg_task
> > > 				run_workqueue
> > 
> > Thanks for the backtrace I'll work on fixing this.
> 
> [ Jeff and co., this is basically the kind of patch I want
>   to see eventually for the Intel drivers too... ]
> 
> Alexey, please try this patch:
> 
> atl1: Do not wake queue before queue has been started.

Patch helps and networking is back with and without using netconsole,
thank you!

Also wan to say, 8139too driver survived multiqueue TX changes fine.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html