netdev - Re: [PATCH 20/31]: pkt_sched: Perform bulk of qdisc destruction in RCU.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080721131918.GA11114@gondor.apana.org.au>
Date:	Mon, 21 Jul 2008 21:19:18 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	jamal <hadi@...erus.ca>
Cc:	davem@...emloft.net, kaber@...sh.net, netdev@...r.kernel.org,
	johannes@...solutions.net, linux-wireless@...r.kernel.org
Subject: Re: [PATCH 20/31]: pkt_sched: Perform bulk of qdisc destruction in	RCU.

On Mon, Jul 21, 2008 at 09:08:44AM -0400, jamal wrote:
>
> The one thing i am unsure of still:
> I think it would be cleaner to just stop a single queue (instead of all)
> when one hardware queue fills up. i.e if there is no congestion on the
> other hardware queues, packets should continue to be fed to their
> hardware queues and not be buffered at qdisc level.

Right you don't necessarily have to stop all queues but you do
need to direct all packets into the qdisc.

> Parallelization would work if you can get X CPUs to send to X hardware
> queues concurently. Feasible in static host setup like virtualization
> environment where you can tie a vm to a cpu. Not very feasible in
> routing where you are driven to a random hardware tx queue by arriving
> packets.

It should work just fine for routing assuming your card does
multi-queue RX.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html