netdev - Re: [PATCH 05/10] r6040: call napi_disable when puting down the interface and set lp->dev accordingly.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080722215218.GB32506@electric-eye.fr.zoreil.com>
Date:	Tue, 22 Jul 2008 23:52:18 +0200
From:	Francois Romieu <romieu@...zoreil.com>
To:	Florian Fainelli <florian.fainelli@...ecomint.eu>
Cc:	netdev@...r.kernel.org, jeff@...zik.org
Subject: Re: [PATCH 05/10] r6040: call napi_disable when puting down the
	interface and set lp->dev accordingly.

Florian Fainelli <florian.fainelli@...ecomint.eu> :
[...]
> Patch attached below

Thanks.

> are you okay with the other patches ?

1) The comment in "[PATCH 06/10] r6040: completely rework the RX path"
seems a it misleading to me:
! ...
! We now allocate skbs on the fly in r6040_rx, and we handle allocation
! failure instead of simply dropping the packet. Remove the
! ...

Afaiks netif_receive_skb is skipped as soon as the allocation fails.
The packet is thus still dropped, isn't it ?

2) I am a bit surprized that r6040_descriptor mixes endian tainted
fields (buf, ndesc) with untainted ones (status, len). It the latter
ought to be tainted too, it could be done in the #define lines of
"[PATCH 07/10] r6040: use definitions for magic values in descriptor status"

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html