[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20080722014042.GA16846@martell.zuzino.mipt.ru>
Date: Tue, 22 Jul 2008 05:40:42 +0400
From: Alexey Dobriyan <adobriyan@...il.com>
To: agl@...erialviolet.org, davem@...emloft.net
Cc: netdev@...r.kernel.org
Subject: Recent tcp_syn_options() buglet
CHECK net/ipv4/tcp_output.c
net/ipv4/tcp_output.c:475:7: warning: dubious: !x & y
And sparse is damn right!
if (unlikely(!OPTION_TS & opts->options))
^^^
size += TCPOLEN_SACKPERM_ALIGNED;
OPTION_TS is (1 << 1), so condition will never trigger.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists