netdev - Re: [2.6 patch] make sctp_outq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 22 Jul 2008 14:05:32 -0400
From:	Neil Horman <nhorman@...driver.com>
To:	Adrian Bunk <bunk@...nel.org>
Cc:	Vlad Yasevich <vladislav.yasevich@...com>,
	"David S. Miller" <davem@...emloft.net>, sri@...ibm.com,
	linux-sctp@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [2.6 patch] make sctp_outq_flush() static

On Tue, Jul 22, 2008 at 08:20:45PM +0300, Adrian Bunk wrote:
> sctp_outq_flush() can now become static.
> 
> Signed-off-by: Adrian Bunk <bunk@...nel.org>
> 
Acked-by: Neil Horman <nhorman@...driver.com>

> ---
> 
>  include/net/sctp/structs.h |    1 -
>  net/sctp/outqueue.c        |    4 +++-
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 
> 9fc45261b127e54b1c5982b629956db9351e3b1f 
> diff --git a/include/net/sctp/structs.h b/include/net/sctp/structs.h
> index 70eb64a..535a18f 100644
> --- a/include/net/sctp/structs.h
> +++ b/include/net/sctp/structs.h
> @@ -1161,7 +1161,6 @@ void sctp_outq_init(struct sctp_association *, struct sctp_outq *);
>  void sctp_outq_teardown(struct sctp_outq *);
>  void sctp_outq_free(struct sctp_outq*);
>  int sctp_outq_tail(struct sctp_outq *, struct sctp_chunk *chunk);
> -int sctp_outq_flush(struct sctp_outq *, int);
>  int sctp_outq_sack(struct sctp_outq *, struct sctp_sackhdr *);
>  int sctp_outq_is_empty(const struct sctp_outq *);
>  void sctp_outq_restart(struct sctp_outq *);
> diff --git a/net/sctp/outqueue.c b/net/sctp/outqueue.c
> index 70ead8d..4328ad5 100644
> --- a/net/sctp/outqueue.c
> +++ b/net/sctp/outqueue.c
> @@ -71,6 +71,8 @@ static void sctp_mark_missing(struct sctp_outq *q,
>  
>  static void sctp_generate_fwdtsn(struct sctp_outq *q, __u32 sack_ctsn);
>  
> +static int sctp_outq_flush(struct sctp_outq *q, int rtx_timeout);
> +
>  /* Add data to the front of the queue. */
>  static inline void sctp_outq_head_data(struct sctp_outq *q,
>  					struct sctp_chunk *ch)
> @@ -712,7 +714,7 @@ int sctp_outq_uncork(struct sctp_outq *q)
>   * locking concerns must be made.  Today we use the sock lock to protect
>   * this function.
>   */
> -int sctp_outq_flush(struct sctp_outq *q, int rtx_timeout)
> +static int sctp_outq_flush(struct sctp_outq *q, int rtx_timeout)
>  {
>  	struct sctp_packet *packet;
>  	struct sctp_packet singleton;
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
/****************************************************
 * Neil Horman <nhorman@...driver.com>
 * Software Engineer, Red Hat
 ****************************************************/
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html