netdev - Re: q == &noop_qdisc warning from 802.11 code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080723.142241.41151635.davem@davemloft.net>
Date:	Wed, 23 Jul 2008 14:22:41 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	johannes@...solutions.net
Cc:	leitao@...ux.vnet.ibm.com, jirislaby@...il.com,
	netdev@...r.kernel.org, flamingice@...rmilk.net,
	linux-wireless@...r.kernel.org
Subject: Re: q == &noop_qdisc warning from 802.11 code

From: Johannes Berg <johannes@...solutions.net>
Date: Wed, 23 Jul 2008 16:53:05 +0200

> 
> > I also hit a bug related to noop_qdisc running the net-next kernel. 
> > I hit this bug every time I run "ifconfig eth0 mtu 9000; ifconfg eth0 1500" for any
> > interface (tested against s2io and e1000) that is up, otherwise the bug isn't
> > reproducible.
> > 
> > The bug dumps the following calltrace: 
> > 
> > [root@...dolphins net-next-2.6]# ifconfig eth0  mtu 9000; ifconfig eth0 mtu 1500
> > ------------[ cut here ]------------
> > kernel BUG at net/core/dev.c:1328!
> 
> > void __netif_schedule(struct Qdisc *q)
> > {
> >         BUG_ON(q == &noop_qdisc);
> > 
> > So, somehow we're reaching __netif_schedule() using a noop_qdisc. 
> 
> Yeah, I'm looking into it. Just removing the netif_wake calls in mlme.c
> might work.

Don't work too hard on this now, I'm removing the warning as I mentioned
in a recent posting.

Most important is the bug where wireless expects the SKB control block
to be untouched across the qdisc layer, which was never true :-)

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html