netdev - Re: [PATCH] Traffic control cgroups subsystem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4887B1F0.3000407@trash.net>
Date:	Thu, 24 Jul 2008 00:34:24 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	Andrew Morton <akpm@...ux-foundation.org>
CC:	Ranjit Manomohan <ranjitm@...gle.com>,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	lizf@...fujitsu.com, menage@...gle.com
Subject: Re: [PATCH] Traffic control cgroups subsystem

Andrew Morton wrote:
> On Tue, 22 Jul 2008 10:44:18 -0700 (PDT)
> Ranjit Manomohan <ranjitm@...gle.com> wrote:
> 
>> @@ -359,7 +370,12 @@ static int flow_classify(struct sk_buff *skb, struct tcf_proto *tp,
>>   			classid %= f->divisor;
>>
>>   		res->class   = 0;
>> -		res->classid = TC_H_MAKE(f->baseclass, f->baseclass + classid);
>> +
>> +		if (key == FLOW_KEY_CGROUP_CLASSID)
>> +			res->classid = TC_H_MAKE(f->baseclass, classid);
>> +		else
>> +			res->classid = TC_H_MAKE(f->baseclass,
>> +						 f->baseclass + classid);
> 
> This causes a warning:
> 
> net/sched/cls_flow.c: In function 'flow_classify':
> net/sched/cls_flow.c:344: warning: 'key' may be used uninitialized in this function
> 
> that warning is a non-issue if we happen to know that f->nkeys can
> never be zero.  I don't know if that is guaranteed at this code site?

It is by the flow_change() function, but special casing the
CGROUP_CLASSID is not acceptable anyway. There should be no
need for that, a simple linear mapping to classids is done
by default in mapping mode, the sk_cgroup_classid simply
shouldn't include qdisc IDs.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html