netdev - Re: [Bugme-new] [Bug 11144] New: dhcp doesn't work with iwl4965

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48875B8C.2090800@trash.net>
Date:	Wed, 23 Jul 2008 18:25:48 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	François Valenduc 
	<francois.valenduc@...ablenet.be>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	bugme-daemon@...zilla.kernel.org, linux-wireless@...r.kernel.org,
	"John W. Linville" <linville@...driver.com>,
	Linux Netdev List <netdev@...r.kernel.org>,
	Jussi Kivilinna <jussi.kivilinna@...et.fi>
Subject: Re: [Bugme-new] [Bug 11144] New: dhcp doesn't work with iwl4965

Patrick McHardy wrote:
> François Valenduc wrote:
>> Patrick McHardy a écrit :
>>>> In file included from net/mac80211/main.c:11:
>>>> include/net/mac80211.h: In function ‘IEEE80211_SKB_CB’:
>>>> include/net/mac80211.h:347: erreur: size of array ‘type name’ is 
>>>> negative
>>>
>>>
>>> I was afraid that might happen. This means skb->cb is not large
>>> enough to hold both the qdisc and the ieee80211 structs.
>>>
>>> Just for testing, changing (include/net/mac80211.h):
>>>
>>> #define IEEE80211_TX_INFO_DRIVER_DATA_SIZE \
>>>         (sizeof(((struct sk_buff *)0)->cb) - 8)
>>>
>>> to
>>>
>>> #define IEEE80211_TX_INFO_DRIVER_DATA_SIZE \
>>>         (sizeof(((struct sk_buff *)0)->cb) - 12)
>>>
>>> might help to get it to compile. If that doesn't work, try -16.
>>>
>>>
>> That didn't work, neither with -12 or -16.
> 
> I'll give it a try myself, please wait a few minutes.

We can't fit them into the cb together, I don't see a way to
shrink ieee80211_tx_info.

Maybe one of the wireless folks can suggest something? Is it
really necessary to pass the full struct ieee80211_tx_info
through the qdisc layer, or could the struct be split? It
needs to find a way to co-exist peacefully with qdiscs'
skb->cb usage.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html