netdev - [PATCH] sctp: list pmtudisc initizlisation for ipv4 sctp socket

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <4888A3C9.3010203@openvz.org>
Date:	Thu, 24 Jul 2008 19:46:17 +0400
From:	Pavel Emelyanov <xemul@...nvz.org>
To:	Vlad Yasevich <vladislav.yasevich@...com>
CC:	linux-sctp@...r.kernel.org,
	Linux Netdev List <netdev@...r.kernel.org>
Subject: [PATCH] sctp: list pmtudisc initizlisation for ipv4 sctp socket

I'm not sure whether this was done deliberately, but the
sctp_v4_create_accept_sk doesn't set the newinet->pmtudisc
like it is done in both cases (ipv4 and v6) for tcp sockets
and for sctp over ipv6 socket.

This loss is painless, I suppose, since the whole socket is
zeroed by default and thus this field is automatically set
to IP_PMTUDISC_DONT.

Restore this setting logic for sctp over ipv4 socket.

Signed-off-by: Pavel Emelyanov <xemul@...nvz.org>

---

diff --git a/net/sctp/protocol.c b/net/sctp/protocol.c
index a6e0818..b05c739 100644
--- a/net/sctp/protocol.c
+++ b/net/sctp/protocol.c
@@ -626,6 +626,11 @@ static struct sock *sctp_v4_create_accept_sk(struct sock *sk,
 	newinet->mc_index = 0;
 	newinet->mc_list = NULL;
 
+	if (ipv4_config.no_pmtu_disc)
+		newinet->pmtudisc = IP_PMTUDISC_DONT;
+	else
+		newinet->pmtudisc = IP_PMTUDISC_WANT;
+
 	sk_refcnt_debug_inc(newsk);
 
 	if (newsk->sk_prot->init(newsk)) {
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html