netdev - Re: [PATCH 2/2] xen-netfront: call netif_start_queue() on xennet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4888CA2A.1060509@garzik.org>
Date:	Thu, 24 Jul 2008 14:30:02 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Jeremy Fitzhardinge <jeremy@...p.org>
CC:	Eduardo Habkost <ehabkost@...hat.com>, Ingo Molnar <mingo@...e.hu>,
	linux-kernel@...r.kernel.org, NetDev <netdev@...r.kernel.org>,
	David Miller <davem@...emloft.net>
Subject: Re: [PATCH 2/2] xen-netfront: call netif_start_queue() on xennet_open()

Jeremy Fitzhardinge wrote:
> Eduardo Habkost wrote:
>> xen-netfront was waking the queue before calling netif_start_queue(),
>> triggering the BUG_ON() on __netif_schedule().
>>
>> Signed-off-by: Eduardo Habkost <ehabkost@...hat.com>
>>   
> Ok,
> Acked-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@...rix.com>
> 
> but Ingo, do you want to pick this up?  You're gathering a collection of 
> these patches anyway, or should we kick it over to Dave/Jeff?
> 
>    J
> 
>> ---
>>  drivers/net/xen-netfront.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
>> index 902bbe7..c749bdb 100644
>> --- a/drivers/net/xen-netfront.c
>> +++ b/drivers/net/xen-netfront.c
>> @@ -329,7 +329,7 @@ static int xennet_open(struct net_device *dev)
>>      }
>>      spin_unlock_bh(&np->rx_lock);
>>  
>> -    xennet_maybe_wake_tx(dev);
>> +    netif_start_queue(dev);

This is clearly a net driver change, it should go this way...

	Jeff



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html