netdev - Re: [patch inside] kernel crash, RTL8101E [10ec:8136]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Thu, 24 Jul 2008 22:23:46 +0200 (MEST)
From:	"martin capitanio" <martin@...itanio.org>
To:	"Cédric Augonnet" 
	<cedric.augonnet@...il.com>,
	"Francois Romieu" <romieu@...zoreil.com>,
	"Mario Limonciello" <Mario_Limonciello@...l.com>
Cc:	kernel@...r.kernel.org, netdev@...r.kernel.org,
	c4p7n1@...itanio.org
Subject: Re: [patch inside] kernel crash, RTL8101E [10ec:8136]

----- original message --------

Subject: Re: [patch inside] kernel crash, RTL8101E [10ec:8136]
Sent: Thu, 24 Jul 2008
From: Cédric Augonnet<cedric.augonnet@...il.com>

> Hi all,
> 
> >        case RTL_GIGA_MAC_VER_04:
> >                rtl8169sb_hw_phy_config(ioaddr);
> >                break;
> > +       case RTL_GIGA_MAC_VER_13:
> > +       case RTL_GIGA_MAC_VER_16:
> > +               rtl8101_hw_phy_config(ioaddr);
> 
> Should not there be a "break;" here or is it intended to go through
> the next case as well?

Good question. If you can read c code and are willing to spend your time,
the answer may be buried here:

LINUX driver for kernel 2.6.X and 2.4.X (Support x86 and x64)
ftp://152.104.238.19/cn/nic/r8101-1.007.00.tar.bz2

> 
> >        case RTL_GIGA_MAC_VER_18:
> >                rtl8168cp_hw_phy_config(ioaddr);
> >                break;
> 
> Perhaps i missed something obvious, sorry if that's the case ...

No, there is nothing obvious, even in the Hsinchu Science Park ;-)

static void rtl8168cp_hw_phy_config(void __iomem *ioaddr)
{
	struct phy_reg phy_reg_init[] = {
		{ 0x1f, 0x0000 },
		{ 0x1d, 0x0f00 },
		{ 0x1f, 0x0002 },
		{ 0x0c, 0x1ec8 },
		{ 0x1f, 0x0000 }
	};

	rtl_phy_write(ioaddr, phy_reg_init, ARRAY_SIZE(phy_reg_init));
}

        Martin Capitanio

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html