netdev - Re: [PATCH] Re: SFQ depth limit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48884133.8070301@trash.net>
Date:	Thu, 24 Jul 2008 10:45:39 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	David Miller <davem@...emloft.net>
CC:	jarkao2@...il.com, denys@...p.net.lb, netdev@...r.kernel.org
Subject: Re: [PATCH] Re: SFQ depth limit

David Miller wrote:
> From: Jarek Poplawski <jarkao2@...il.com>
> Date: Sun, 29 Jun 2008 21:11:13 +0200
>
>   
>> sch_sfq: dump a real number of flows
>>
>> Dump the "flows" number according to the number of active flows
>> instead of repeating the "limit".
>>     
>
> Looks reasonable, applied, thanks Jarek.

I'm not sure we should do this, this removes the symetry between
->init/change and ->dump. Its not a big deal in this case since
flows is unused in ->init anyway, but still its a not so nice
precedent. Such things should normally be put in the statistics.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html