netdev - Re: [PATCH] IPVS: Move userspace definitions to include/linux/ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080724002057.GA3032@verge.net.au>
Date:	Thu, 24 Jul 2008 10:20:59 +1000
From:	Simon Horman <horms@...ge.net.au>
To:	David Miller <davem@...emloft.net>
Cc:	lvs-devel@...r.kernel.org, netdev@...r.kernel.org,
	juliusv@...gle.com, kaber@...sh.net, vbusam@...gle.com
Subject: Re: [PATCH] IPVS: Move userspace definitions to
	include/linux/ip_vs.h

On Wed, Jul 23, 2008 at 04:42:15PM -0700, David Miller wrote:
> From: Simon Horman <horms@...ge.net.au>
> Date: Tue, 22 Jul 2008 10:37:57 +1000
> 
> > From: Julius Volz <juliusv@...gle.com>
> > 
> > Current versions of ipvsadm include "/usr/src/linux/include/net/ip_vs.h"
> > directly. This file also contains kernel-only definitions. Normally, public
> > definitions should live in include/linux, so this patch moves the
> > definitions shared with userspace to a new file, "include/linux/ip_vs.h".
> > 
> > To make old ipvsadms still compile with this, the old header file includes
> > the new one.
> > 
> > The motivation for this cleanup is the planned Netlink interface for IPVS.
> > 
> > Signed-off-by: Julius Volz <juliusv@...gle.com>
> > Acked-by: Simon Horman <horms@...ge.net.au>
> 
> Userland exported headers need to have an entry in include/linux/Kbuild
> 
> Since this linux/ip_vs.h file is new, a new entry needs to be added there.

Thanks, I wasn't aware of that.

Julius, I think this is the bit we are missing:

Index: net-next-2.6/include/linux/Kbuild
===================================================================
--- net-next-2.6.orig/include/linux/Kbuild	2008-07-24 10:15:52.000000000 +1000
+++ net-next-2.6/include/linux/Kbuild	2008-07-24 10:19:08.000000000 +1000
@@ -97,6 +97,7 @@ header-y += ioctl.h
 header-y += ip6_tunnel.h
 header-y += ipmi_msgdefs.h
 header-y += ipsec.h
+header-y += ip_vs.h
 header-y += ipx.h
 header-y += irda.h
 header-y += iso_fs.h
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html