netdev - Re: [PATCH] IPVS: Move userspace definitions to include/linux/ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48886A3C.7050906@trash.net>
Date:	Thu, 24 Jul 2008 13:40:44 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	Julius Volz <juliusv@...gle.com>
CC:	Simon Horman <horms@...ge.net.au>, lvs-devel@...r.kernel.org,
	netdev@...r.kernel.org, davem@...emloft.net, vbusam@...gle.com
Subject: Re: [PATCH] IPVS: Move userspace definitions to include/linux/ip_vs.h

Julius Volz wrote:
> On Thu, Jul 24, 2008 at 1:22 PM, Patrick McHardy <kaber@...sh.net> wrote:
>>>> +/* Move it to better place one day, for now keep it unique */
>>>> +#define NFC_IPVS_PROPERTY      0x10000
>> Does this have any connection to the skb flag? If so, does
>> it really belong in the userspace interface?
> 
> This doesn't seem to be used at all anymore, but I didn't want to
> remove it in the same patch... should I?

I'm not sure if this is (or has been) used by userspace, someone
more familiar with IPVS should answer that.

>>>> +struct ip_vs_service_user {
>>>> +       /* virtual service addresses */
>>>> +       u_int16_t               protocol;
>>>> +       __be32                  addr;           /* virtual ip address */
>>>> +       __be16                  port;
>> If you switch the above two you plug two holes in the struct.
> 
> Unfortunately, these structs all have to stay as they are because they
> are used by old ipvsadms. That was the whole reason for implementing
> the Netlink interface.

Ah I see, I assumed you would be using them in the new
interface :) So thats fine obviously.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html