netdev - Re: [RFC][PATCH 1/3] net: per skb control messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <E1KM0DG-0001vY-00@gondolin.me.apana.org.au>
Date:	Thu, 24 Jul 2008 20:46:30 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	opurdila@...acom.com (Octavian Purdila)
Cc:	netdev@...r.kernel.org, opurdila@...acom.com
Subject: Re: [RFC][PATCH 1/3] net: per skb control messages

Octavian Purdila <opurdila@...acom.com> wrote:
> This patch introduces per skb control messages that can be used to
> directly exchange information between the application and the
> hardware, at a per packet level. Examples of usecases are: RX/TX
> hardware timestamps, TX scheduling (request hardware to send packets
> at a future time).

Putting it in the share info area makes its life-cycle management
difficult.  This is also a major change to how we store skb control
data.

> @@ -567,6 +612,8 @@ static void copy_skb_header(struct sk_buff *new, const struct sk_buff *old)
>        skb_shinfo(new)->gso_size = skb_shinfo(old)->gso_size;
>        skb_shinfo(new)->gso_segs = skb_shinfo(old)->gso_segs;
>        skb_shinfo(new)->gso_type = skb_shinfo(old)->gso_type;
> +
> +       skb_shinfo(new)->cmsg = skb_shinfo(old)->cmsg;
> }
> 
> /**
> @@ -610,7 +657,8 @@ struct sk_buff *skb_copy(const struct sk_buff *skb, gfp_t gfp_mask)
>                BUG();
> 
>        copy_skb_header(n, skb);
> -       return n;
> +
> +       return skb_cmsg_copy(n, gfp_mask);

What about the other callers of copy_skb_header, like pskb_copy?
In fact why isn't this in copy_skb_header?

Also what about pskb_expand_head?

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html