netdev - Re: [PATCH] IPVS: Move userspace definitions to include/linux/ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080725001856.GB3896@verge.net.au>
Date:	Fri, 25 Jul 2008 10:18:58 +1000
From:	Simon Horman <horms@...ge.net.au>
To:	Julius Volz <juliusv@...gle.com>
Cc:	Patrick McHardy <kaber@...sh.net>, lvs-devel@...r.kernel.org,
	netdev@...r.kernel.org, davem@...emloft.net, vbusam@...gle.com
Subject: Re: [PATCH] IPVS: Move userspace definitions to
	include/linux/ip_vs.h

On Thu, Jul 24, 2008 at 01:46:38PM +0200, Julius Volz wrote:
> On Thu, Jul 24, 2008 at 1:40 PM, Patrick McHardy <kaber@...sh.net> wrote:
> > Julius Volz wrote:
> >>
> >> On Thu, Jul 24, 2008 at 1:22 PM, Patrick McHardy <kaber@...sh.net> wrote:
> >>>>>
> >>>>> +/* Move it to better place one day, for now keep it unique */
> >>>>> +#define NFC_IPVS_PROPERTY      0x10000
> >>>
> >>> Does this have any connection to the skb flag? If so, does
> >>> it really belong in the userspace interface?
> >>
> >> This doesn't seem to be used at all anymore, but I didn't want to
> >> remove it in the same patch... should I?
> >
> > I'm not sure if this is (or has been) used by userspace, someone
> > more familiar with IPVS should answer that.
> 
> I don't think so. It was once used as a bitmask into skb->nfcache,
> which does not even exist anymore. There's no use of it in the current
> ipvsadm. I think it can go away, I'll post an updated patch again.

I'm pretty sure that it is safe to get rid of NFC_IPVS_PROPERTY

-- 
Horms

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html