netdev - Re: [PATCH] Variables only used in ifdef

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4889453A.8070002@cn.fujitsu.com>
Date:	Fri, 25 Jul 2008 11:15:06 +0800
From:	Wang Chen <wangchen@...fujitsu.com>
To:	Jeff Garzik <jgarzik@...ox.com>
CC:	NETDEV <netdev@...r.kernel.org>
Subject: Re: [PATCH] Variables only used in ifdef

Wang Chen said the following on 2008-7-4 16:25:
> Move the variables which only used in #ifdef to where they should be.
> Otherwise, "defined but not used" compile warning will go out.
> 
> Signed-off-by: Wang Chen <wangchen@...fujitsu.com>
> ---
> diff --git a/drivers/net/wan/syncppp.c b/drivers/net/wan/syncppp.c
> index 29b4b94..c938d4c 100644
> --- a/drivers/net/wan/syncppp.c
> +++ b/drivers/net/wan/syncppp.c
> @@ -763,10 +763,10 @@ static void sppp_cisco_input (struct sppp *sp, struct sk_buff *skb)
>  	case CISCO_ADDR_REQ:
>  		/* Stolen from net/ipv4/devinet.c -- SIOCGIFADDR ioctl */
>  		{
> -		struct in_device *in_dev;
> -		struct in_ifaddr *ifa;
>  		__be32 addr = 0, mask = htonl(~0U); /* FIXME: is the mask correct? */
>  #ifdef CONFIG_INET
> +		struct in_device *in_dev;
> +		struct in_ifaddr *ifa;
>  		rcu_read_lock();
>  		if ((in_dev = __in_dev_get_rcu(dev)) != NULL)
>  		{
> 

Jeff, will you take this?

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html